Closed Prof-Bloodstone closed 2 years ago
Running latest script freshly without the
data/
dir existing results in:Traceback (most recent call last): File "<PATH>/update.py", line 489, in <module> event.webranking = sorted(event.webranking, key = lambda i: i['value'], reverse=True) AttributeError: 'EventStat' object has no attribute 'webranking'
That's not good, I'll have a look.
Looks like 2ae7aee might have broken it, since
EventStat
only hasranking
: 2ae7aeeI can confirm that running global replace
s/webranking/ranking/g
on the update script results in no errors from the script.
That sounds like a bad idea, because that commit fixed the ranking display being one update behind all the time. This bug should be fixed properly, probably by initializing the webranking as empty when it doesn't exist.
Running latest script freshly without the
data/
dir existing results in:Looks like https://github.com/pdinklag/MinecraftStats/commit/2ae7aee2ec77c41ca79bb597b9944a3d249a1487 might have broken it, since
EventStat
only hasranking
: https://github.com/pdinklag/MinecraftStats/commit/2ae7aee2ec77c41ca79bb597b9944a3d249a1487I can confirm that running global replace
s/webranking/ranking/g
on the update script results in no errors from the script.Let me know if I should PR this as fix :)