search

pdinklag / MinecraftStats

A Minecraft player statistics browser for the web - supports 1.13 and later!
https://discord.gg/brH5PGG8By
Other
230 stars 55 forks source link

Event winner display fix #242

Closed tylerguy closed 4 months ago

tylerguy commented 9 months ago

Wasn't sure if this was being worked on at all but I know in the past there's been a couple of issues relating to this, #175 #189 etc.

Since the switch to java, event winners haven't displayed properly in either ongoing or ended events. This fix simply reads each event json and gets the first value in the ranking array since from what I can tell they're processed to be in order.

Since this is simply a frontend change, should work for either plugin or cli. Working implementation can be found here so you can verify the fix

pdinklag commented 9 months ago

I have opened #243 for this issue.

As to your fix, I don't really think it's a good idea to fix a relatively simple backend problem by changing the frontend, especially in a way that may cause a lot of unnecessary traffic. The event rankings are stored in separate files so they only have to be loaded when showing the ranking. Your fix causes every event ranking to be loaded just to show the list of events, which won't scale well for large servers with many events.

tylerguy commented 4 months ago

Closing this pr since the changes in v3.3.1 fix the issue 🙂