search

pdinklag / MinecraftStats

A Minecraft player statistics browser for the web - supports 1.13 and later!
https://discord.gg/brH5PGG8By
Other
227 stars 53 forks source link

Updating Skins Fails #44

Closed geekrawker closed 5 years ago

geekrawker commented 5 years ago

Only issue I'm having with the past 2 updates is "Failed to update skins". All new players on the board show only default skins. Screen Shot 2019-05-31 at 12 48 21 AM Screen Shot 2019-05-31 at 12 48 41 AM

pdinklag commented 5 years ago

What do you mean by "past 2 updates"? Updates of MinecraftStats, or updates of Minecraft?

Nothing changed regarding skins in this project, so this would be important to know. If Mojang changed something about how the skins are retrieved, that would explain.

pdinklag commented 5 years ago

OK, just tried and it is working fine on my side, so we can exclude a change on Mojang's side.

I will make a commit in a few minutes that prints a few more details about why it failed, because I need some more detailled info here.

geekrawker commented 5 years ago

ah, downloaded one of the -master zip's a few months back, but didn't apply it to the 1.13 sever.

Getting the 1.14 version of our server ready 3 weeks ago and started using that particular download. No custom skins loaded (no big deal still prepping the server), noticed you all posted some changes the past couple days and we are close to releasing our 1.14 server. Unpacked the latest zip and re-ran the typical update.py command. Still No joy, but thx for the reply must be something broken on my end then.

pdinklag commented 5 years ago

Try again wtih the updated script, hopefully it gives some hints as to what's wrong.

geekrawker commented 5 years ago

Thanks - I'm getting 2 different errors now.

1) (using only your new update.py) "updating skin for Nicoli ... failed to update skin for Nicoli global name 'urllib' is not defined"

Then tried replacing the entire -Master folder with a fresh download... now i get this error:

2) "Traceback (most recent call last): File "update.py", line 14, in import mojang File "--removed my server path--MinecraftStats-master\mojang.py", line 3, in import urllib.request ImportError: No module named request

geekrawker commented 5 years ago

Solved, Python 2.7 is not compatible with urllib.request in the Mojang.py.
Tried to use urllib2, but simply updating to python 3.8 resolved the issue. Thanks for printing the error, would have never noticed it was my python version. :D 👍