search

pdinklag / MinecraftStats

A Minecraft player statistics browser for the web - supports 1.13 and later!
https://discord.gg/brH5PGG8By
Other
228 stars 54 forks source link

Add phpunit tests #8

Closed bmarwell closed 6 years ago

bmarwell commented 7 years ago

Hi,

actually, I just wanted to say thank you :+1:

Anyway, I think there would be room for improvements like adding phpunit tests.

I haven't followed development lately. In my fork (outdated), I added a responsive layout for mobile devices. If you haven't got these modifications yet, I'd be happy to create another issue and merge those changes. See: https://github.com/bmhm/MinecraftStats/compare/4d01f56f13cd53305f47986bf6bae5719215277f...master

Thanks, and happy crafting!

pdinklag commented 7 years ago

Hey! Thank you for using this and for contributing! 😄

I'm not sure what unit tests would make sense for this kind of application, most operations are fairly simple. The only thing that comes to mind would be security, that area has not really been considered in this project (other than the obvious cross-scripting avoiders, I hope).

Do you have some concrete suggestions?

Re responsive layout: I'll open another issue on that, the layout is currently a problem even in desktop browsers. However, I'm generally sceptical about third party stuff in custom web applications. 😉

pdinklag commented 6 years ago

Closing due to inactivity, and because version 2 will not be PHP-based anyway.