Special characters in server.properties.motd cause loading failure

pdinklag / MinecraftStats

A Minecraft player statistics browser for the web - supports 1.13 and later!

https://discord.gg/brH5PGG8By

Other

227 stars 53 forks source link

Special characters in server.properties.motd cause loading failure #80

Closed ColinHaley closed 4 years ago

ColinHaley commented 4 years ago

I've only tested so far with an exclamation point, but I am working under the assumption it may be similar for other special characters due to forced escape characters "\" in MOTD field.

Works: motd=test Broken: motd=test!

pdinklag commented 4 years ago

You mean the site being stuck at "Loading" in the browser, right? Looks like I need to reconsider how it's parsed into the client. :roll_eyes: Thanks for reporting!

cunhar commented 4 years ago

This is still breaking with \n in the MOTD i added a quick sting replace before the json.parse

pdinklag commented 4 years ago

Yes, there is a new open issue on it (#94).