search

pdinsdale / BattleBot

Discord.js bot for the 1-Up World Discord server
https://discord.gg/mario
5 stars 3 forks source link

Duplicate code, consider revising #15

Closed sdace closed 5 years ago

sdace commented 5 years ago

https://github.com/Phoenix1128/BattleBot/blob/0e8036a213d047f0370e6fa6fd571998215a233a/commands/factions/1ups.js#L26

There should be no references to 'mario' or 'luigi' in the bot's code. Ideally, more than 2 factions should be supported, but for now I would work on refactoring this code so you're not repeating the same blocks of code twice when you could just be passing in parameters to a single function.

sdace commented 5 years ago

Any references to strings, if absolutely necessary, should also be defined as constants in some central location so they can be changed throughout the code.

pdinsdale commented 5 years ago

Yeah this is something I’ve also fixed in the Development branch just not master yet.

pdinsdale commented 5 years ago

Fixed with v1.2.0!