search

pdinsdale / BattleBot

Discord.js bot for the 1-Up World Discord server
https://discord.gg/mario
5 stars 3 forks source link

Current year is hard coded #16

Closed sdace closed 5 years ago

sdace commented 5 years ago

https://github.com/Phoenix1128/BattleBot/blob/0e8036a213d047f0370e6fa6fd571998215a233a/commands/factions/results.js#L12

This should definitely not be hard-coded. Please use the Date class to check if the queried year is greater than the current, then same for the month.

pdinsdale commented 5 years ago

Yes agreed. Also gonna update this with the results restructuring.

pdinsdale commented 5 years ago

Actually completely got rid of this in v1.2.1 cause it was kinda clogging up the code and wasn't really necessary