search

pdinsdale / BattleBot

Discord.js bot for the 1-Up World Discord server
https://discord.gg/mario
5 stars 3 forks source link

Reducing 8-ball complexity #18

Closed sdace closed 5 years ago

sdace commented 5 years ago

https://github.com/Phoenix1128/BattleBot/blob/0e8036a213d047f0370e6fa6fd571998215a233a/commands/fun/8ball.js#L10

suggestion Strings should just be in a numbered array, and you use the random number as an index into it. No need for a long switch case.

pdinsdale commented 5 years ago

That’s true. I’ll get to work on that

pdinsdale commented 5 years ago

Fixed in v1.2.1!