search

pdm-project / pdm-venv

A plugin for pdm that enables virtualenv management
https://pdm-project.github.io/pdm-venv
MIT License
24 stars 4 forks source link

[Feature] add option to purge created Virtualenvs #21

Closed jamestansx closed 2 years ago

jamestansx commented 2 years ago

Hi, the rationale behind this PR are:

  1. to be able to remove Virtualenvs that the associated projects are deleted.
  2. to be able to remove all Virtualenvs at once for cleanup purpose

This implementation might not be neat, please review it. Thanks!

jamestansx commented 2 years ago

I have added --interactive mode to allow users to select particular venv to be removed.

The difference between purge and remove is:

This is to give option to user for maintain the venv created (for disk space or for cleanup).

frostming commented 2 years ago

Mostly good, a few test cases to verify the change are needed before merging.

jamestansx commented 2 years ago

I have added the test, please review it. Thanks.

frostming commented 2 years ago

LGTM, thanks for your effort