search

pdm-project / pdm-venv

A plugin for pdm that enables virtualenv management
https://pdm-project.github.io/pdm-venv
MIT License
24 stars 4 forks source link

add support local venv creation #20 #22

Closed jamestansx closed 2 years ago

jamestansx commented 2 years ago

This pr is to add option to create virtualenv in local project dir.

Ref: #20

frostming commented 2 years ago

I think changing venv.location to the project root should work. And the venvs can be managed by list, remove and purge commands. We don't need another option.

jamestansx commented 2 years ago

Just that setting the venv.location to project root would break purge command.

jamestansx commented 2 years ago

Hi, I just have some thoughts about this. Because venv.location can only be set globally and not in the project, I think it would be better if pdm-venv can have an optional argument to create venv in the local project instead of setting it globally. Thoughts?

frostming commented 2 years ago

If that is the case I think it is better to allowing setting venv.location per project

jamestansx commented 2 years ago

Hi, sorry for late reply, was busy working on school projects. Following your reply, I think I will close this PR and open a new one (if needed).