pdm-project / update-deps-action

A github action to update pdm lock file
MIT License
25 stars 6 forks source link

DCO and option to have signed-off-by in commit messages #4

Closed ModeSevenIndustrialSolutions closed 11 months ago

ModeSevenIndustrialSolutions commented 11 months ago

This app is quite widely used by GitHub projects: https://probot.github.io/apps/dco/

Without a "signed-off-by" message in commits, a PR submitted to a repository with this App cannot be merged directly in the GitHub portal. For the "update-deps-action" workflow/action, this creates unnecessary friction to getting the automatically generated pull requests merged. Could we create a new boolean input flag to have this automatically added, the equivalent of passing "-s" for "git commit"? Otherwise we have to pull down the PR and manually amend the commit message. I'm guessing this same outcome could be created by setting the commit message to a multiline message containing the necessary text, but that seems somewhat messy?

frostming commented 11 months ago

I don't think this is a hard one to do. So are you willing to contribute?

ModeSevenIndustrialSolutions commented 11 months ago

Please see my pull request here: https://github.com/pdm-project/update-deps-action/pull/5 I noticed you were using EndBug and it already has this feature available: https://github.com/EndBug/add-and-commit It was just a matter of creating a new boolean flag as an optional input and passing that through at the time the commit message is generated. I have tested this and automatic changes now pass DCO verification when the app is installed in a given project/repo.

ModeSevenIndustrialSolutions commented 11 months ago
image
ModeSevenIndustrialSolutions commented 11 months ago
image
ModeSevenIndustrialSolutions commented 11 months ago

Added some screenshots to show testing/demonstration.