pdmark / openjpeg

Automatically exported from code.google.com/p/openjpeg
Other
0 stars 0 forks source link

pi.c copy paste mistakes ? #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi everybody,

I'm not sure of that but I detected what I believe to be little mistakes in 
pi.c source file 
(http://code.google.com/p/openjpeg/source/browse/trunk/libopenjpeg/pi.c) :

at line 212:
if (!((pi->y % (comp->dy << rpy) == 0) || ((pi->y == pi->ty0) && ((try0 << 
levelno) % (1 << rpx))))){

shouldn't rpx be rpy at the end of the line ?

line 219:
if ((res->pw==0)||(res->pw==0)) continue;

res->pw twice ? I think it should be if ((res->pw==0)||(res->ph==0)) ..

the same mistakes (if they are mistakes) are reproduced at lines : 293, 300, 
372 and 379

thanks

Original issue reported on code.google.com by anton.li...@gmail.com on 25 Feb 2010 at 9:07

GoogleCodeExporter commented 9 years ago
Thanks for catching this amazing bug ! I fixed the code (rev 561 and 562).

Original comment by fodev...@gmail.com on 8 Apr 2010 at 6:44