search

pdmfc / nova-action-button

MIT License
38 stars 29 forks source link

Ability to define CSS button styles #6

Closed Otienoh closed 2 years ago

Otienoh commented 4 years ago

Hey Buddy, neat package. is it possible to a the ability to define the button CSS when defining the button? Thinking of something along the lines of ->styles('primary-outline') or ->styles('info').

dillingham/nova-button packages Has it implemented.

skoyah commented 4 years ago

Hi @Otienoh ! Thanks for the feedback!

I think your point is valid. This can be a nice feature to have. The only thing I'm not sure is if it should append the classes or completely override them.

I'll tackle this as soon as I get some free time. Also, PRs are always welcomed! :)

Otienoh commented 4 years ago

Yes, that is a good question. I think it will make sense to override the styles as one may want to use a warning default style for the button. In such a case I am not sure appending will work well.

AbdLateef commented 3 years ago

I have the same issue. Did you already make PR @Otienoh ?