Closed catern closed 2 years ago
This test failure was introduced in commit d68abccc5b616917a092ba2b940dd96112090826 and is present in CPython 3.9 and not present in CPython 3.8.
Which was introduced by PR #242 - @RaduG do you know what might be the right fix for this test failure?
Hi @catern, this issue is caused by Python's typing.Generic
class:
typing.Generic
defines a __new__
magic methodThe fix would be to stop using typing.Generic
as a base and just create a base class that implements __new__
. This does not affect the functionality in the PR, it's just a test detail. Happy to address this.
Expected Behavior
All tests pass - they were run as part of this package update: https://github.com/NixOS/nixpkgs/pull/135261
Actual Behavior
test_Class_params fails with
Steps to Reproduce
Run the tests on version 0.10.0 on PyPI. We're doing through
python setup.py test
.Additional info