search

pdolder / MixFishSim

Code for mixed fishery multi-stock simulation model
GNU General Public License v3.0
3 stars 3 forks source link

Days per week that are fished is fixed at 5 #4

Open Blevy2 opened 2 years ago

Blevy2 commented 2 years ago

Hi @pdolder ,

I believe that regardless of what is set for n_days_wk_fished in an init_sim call, the init_sim script fixes the days fished to be 5. This occurs in init_sim on lines 73 & 74 where day.seq and day.breaks are created. Each of these lines contains day.seq[!day.seq %in% c(seq(7,364,7),seq(6,364,7))] which causes fishing to avoid weekends and instead fish during the 5-day work week.

I apologize for the burst of issues I have submitted over the last few days. In preparing a simulation I am discovering minor bugs here and there that I thought would be best to document them as they come up.

Ben Levy

pdolder commented 2 years ago

Hi Ben,

No, please do keep them coming - really useful to have another set of fresh eyes on it all. If you've any suggested changes, feel free to submit too.

Cheers, Paul