Is spwn_mult hardcoded?

[Blevy2]

Hi Paul,

I was working on getting more of the population to move to the spawning grounds during spawning weeks and noticed that regardless of what is entered for spwn_mult in a create_hab call, the value is fixed at 10 in create_hab.

I am not sure why this is happening because even though 10 is set as the default in create_hab, it should be able to be overwritten. One can instead fix the value of spwn_mult inside create_hab as a work around.

best,

Ben Levy

[pdolder]

Hi Ben,

Is it this bit here: https://github.com/pdolder/MixFishSim/blob/f4be072ef8328845a635e68d69a290be4b944fa5/R/create_hab.R#L104

?

I can see mult input is fixed to 2. That's maybe the problem?

Paul

On Wed, 5 Jan 2022, 15:57 Blevy2, @.***> wrote:

Hi Paul,

I was working on getting more of the population to move to the spawning grounds during spawning weeks and noticed that regardless of what is entered for spwn_mult in a create_hab call, the value is fixed at 10 in create_hab.

I am not sure why this is happening because even though 10 is set as the default in create_hab, it should be able to be overwritten. One can instead fix the value of spwn_mult inside create_hab as a work around.

best,

Ben Levy

— Reply to this email directly, view it on GitHub https://github.com/pdolder/MixFishSim/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4F4SJFIW4TCUWXDSBJ3VTUUSWDVANCNFSM5LK2NXNQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

[Blevy2]

Hi Paul,

I had noticed that spwn_mult was fixed as 2 there, but I do not think that is the problem. Correct me if I am wrong but I don't see anywhere that spwn_loc is used in the package so I do not think this has an impact.

I had previously made my own version of create_hab to define strata within a domain for stratified random sampling. When I add spwn_mult <- 20 to the top of my create_hab it seems to override the hardcode and create a different spawning habitat.

Ben

[Blevy2]

To clarify further, I added print(spwn_mult) to the top of my create_hab code and regardless of what I entered for spwn_mult (ex, create_hab(spwn_mult = 100) it was printing out spwn_mult as 10

Ben

[pdolder]

Ok, thanks. It's strange then that the default is not being overwritten by the user input. I'll have to take a closer look at it.

Paul

On Wed, 5 Jan 2022, 16:25 Blevy2, @.***> wrote:

To clarify further, I added print(spwn_mult) to the top of my create_hab code and regardless of what I entered for spwn_mult (ex, create_hab(spwn_mult = 100) it was printing out spwn_mult as 10

Ben

— Reply to this email directly, view it on GitHub https://github.com/pdolder/MixFishSim/issues/8#issuecomment-1006089529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4F4SMXLVXXDZITB7CFXQTUUSZM7ANCNFSM5LK2NXNQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

[Blevy2]

I agree. I am pretty confused by this. Ill let you know if I figure it out.

Ben

[Blevy2]

Hi Paul,

Chris Legault helped me figure out what was happening here. There is no error in the source code, I just did not notice a misplaced parenthesis in Simple_MixFishSim_Example.Rmd in the create_hab call the lines 87-95.

spawn_mult is inside of the spawn_areas list so create_hab does not overwrite the default of 10. Nothing big here. Sorry I did not notice that myself.

Ben

[pdolder]

Thanks Ben, I'll make sure to update the vignette - didn't see that extra parenthesis!

Paul

On Fri, 7 Jan 2022 at 17:01, Blevy2 @.***> wrote:

Hi Paul,

Chris Legault helped me figure out what was happening here. There is no error in the source code, I just did not notice a misplaced parenthesis in Simple_MixFishSim_Example.Rmd in the create_hab call the lines 87-95 https://github.com/pdolder/MixFishSim/blob/f4be072ef8328845a635e68d69a290be4b944fa5/vignettes/Simple_MixFishSim_Example.Rmd#L87-L95 .

spawn_mult is inside of the spawn_areas list so create_hab does not overwrite the default of 10. Nothing big here. Sorry I did not notice that myself.

Ben

— Reply to this email directly, view it on GitHub https://github.com/pdolder/MixFishSim/issues/8#issuecomment-1007571665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4F4SJTYCR3AYHM5XUFNVDUU4L5NANCNFSM5LK2NXNQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

[pdolder]

Fixed vignette.