search

pdphilip / laravel-opensearch

An OpenSearch implementation of Laravel's Eloquent ORM
MIT License
16 stars 1 forks source link

Support for connection params #5

Open ftrudeau-pelcro opened 2 months ago

ftrudeau-pelcro commented 2 months ago

Hey @pdphilip, not an issue, just a small contrib.

I forked your repo and added this small change.

Not sure your repo is ready to accept PRs, so feel free to include this in an upcoming release on your side.

pdphilip commented 2 months ago

This is great @ftrudeau-pelcro

I'll bring in your PR and also include the option to have multiple connections as I did for the Elasticsearch version in the next release.

Thanks!

pdphilip commented 1 month ago

Hey @ftrudeau-pelcro - Do you want to do a PR of this and join as a contributor?

I'm busy with the next release which will be ready soon and would like to include this upgrade. Thanks!

ftrudeau-pelcro commented 1 month ago

@pdphilip - Sure, add me as a collaborator. Pretty busy at work, but I'll try to budget time to create the PR. Probably won't have time to introduce feature tests tho.

pdphilip commented 1 month ago

No rush, I'll put out the new release today (without your changes), then when you're ready, fork the latest version (there's been changes to the connection file), make your edits and submit the PR.

Once I accept the PR, you'll automatically be added as a collaborator on the package home page.