search

pdqcom / PowerShell-Scanners

A community repository of PowerShell Scanners for PDQ Inventory.
MIT License
179 stars 74 forks source link

Add WizTree scanners #72

Closed ColbyBouma closed 3 years ago

ColbyBouma commented 3 years ago

I think these would make a great blog post. 😉

Jordan-PDQ commented 3 years ago

This runs great, we did run into an issue with github desktop because it has a comma in it's path and made it throw an error. as that is the delimiter. Can you think of anything that might work around this very rare test case?

ColbyBouma commented 3 years ago

Weird, I thought I accounted for that. Can you post the full error and path please?

Jordan-PDQ commented 3 years ago

It looks like it splits it at "Github," and tries to convert " inc\" into an integer. I manually removed that comma and everything worked great. I can't think of any other application that puts a comma in it, and ironically I installed the application to test this pull request.

Path: C:\Users\user\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\GitHub, Inc\

Error: Cannot convert value " Inc\" to type "System.UInt64". Error: "Input string was not in a correct format." At line:44 char:5

ColbyBouma commented 3 years ago

Ah, I see what the issue is. I assumed I didn't need "comma in the filename" handling in the User Profiles script, but I was wrong. I can fix that real quick.

ColbyBouma commented 3 years ago

OK, it should be fixed now 🤞

PDQ-Zach commented 3 years ago

Andrew and I did a rebase and merge because Jordan said all was well