pdqcom / PowerShell-Scanners

A community repository of PowerShell Scanners for PDQ Inventory.
MIT License
179 stars 74 forks source link

Hosts File scanner does not update results when scanning empty hosts file #83

Closed GibbyPDQ closed 2 years ago

GibbyPDQ commented 2 years ago

It has been reported that the Hosts File scanner does not update data in Inventory if the Hosts file is blank. Testing will need to be done to verify, if confirmed scanner will need to be modified to account for empty Hosts files.

https://github.com/pdq/PowerShell-Scanners/tree/master/PowerShell%20Scanners/Hosts%20File

ColbyBouma commented 2 years ago

Dear PDQ, please fix Inventory itself. That bug has existed for well over a year. "Fixing" each PowerShell script is a poor solution.

AndrewPla commented 2 years ago

@ColbyBouma I appreciate your feedback and have shared it internally. We are hoping that this gets fixed soon and is high up on the list, but unfortunately don't have a timeline to share with you at this time.

Anumann commented 2 years ago

Hi,

Does that mean the scanner will gracefully handle an empty hosts file? Are you able to provide any more detail before closing this please?

--

Alexander Numann

Lead Mechanical Engineer

He / Him / His

https://productdevelopment.nextfab.com/?utm_source=staff&utm_medium=email&utm_campaign=signature

productdevelopment.nextfab.com https://productdevelopment.nextfab.com/?utm_source=staff&utm_medium=email&utm_campaign=signature

2025 Washington Ave. Philadelphia, PA

On Mon, Mar 28, 2022 at 4:06 PM Andrew Pla @.***> wrote:

Closed #83 https://github.com/pdq/PowerShell-Scanners/issues/83.

— Reply to this email directly, view it on GitHub https://github.com/pdq/PowerShell-Scanners/issues/83#event-6321379917, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMR2QUN2SO32XDTTLZXTTVLVCIGMHANCNFSM5L7X4FNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

AndrewPla commented 2 years ago

Hi @Anumann, apologies for the lack of clarity on my part. We merged a change in #88 to fix this.

Anumann commented 2 years ago

Hi Andrew,

Got it, understood. Thanks for the quick response!

--

Alexander Numann

Lead Mechanical Engineer

He / Him / His

https://productdevelopment.nextfab.com/?utm_source=staff&utm_medium=email&utm_campaign=signature

productdevelopment.nextfab.com https://productdevelopment.nextfab.com/?utm_source=staff&utm_medium=email&utm_campaign=signature

2025 Washington Ave. Philadelphia, PA

On Mon, Mar 28, 2022 at 4:10 PM Andrew Pla @.***> wrote:

Hi @Anumann https://github.com/Anumann, apologies for the lack of clarity on my part. We merged a change in #88 https://github.com/pdq/PowerShell-Scanners/pull/88 to fix this.

— Reply to this email directly, view it on GitHub https://github.com/pdq/PowerShell-Scanners/issues/83#issuecomment-1081090935, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMR2QULSKE4NGJXAKDENHVTVCIG4DANCNFSM5L7X4FNA . You are receiving this because you were mentioned.Message ID: @.***>