search

pdreker / fritz_exporter

Prometheus exporter for Fritz!Box home routers
Other
144 stars 32 forks source link

chore: bump Helm chart to 0.2.0, app version to 2.5.0 #332

Closed embik closed 1 month ago

embik commented 1 month ago

Hey @pdreker, thank you for fritz_exporter! Really great project.

I came across it and used the Helm chart to deploy it, works like a charm. Only modification I had to make was to bump the appVersion to 2.5.0 so it would use the latest version of the exporter (2.2.0 is pretty old at this point, after all).

Helm charts also need a version bump usually, so I took the freedom to bump it from 0.1.0 to 0.2.0 since it has been sitting at that version for a bit too long maybe.

Hope this PR is helpful you, I saw that the Helm chart was considered "a hot mess" at some point, but it seems to be quite solid. If this isn't desired, feel free to close the PR!

pdreker commented 1 month ago

Hi and sorry for the long time before responding :-)

I'll take your PR, even if I normally wouldn#t have bumped the Helm Chart version for that kind of change, but this isn't about sticking to some arbitrary set of rules but delivering something useful.

So thanks for your contribution, I'll merge right away, as soon as dependabot has done its magic.