Closed pdrhlik closed 6 years ago
related to #15
Because of #19, we have to include automatic README.Rmd rendering. Best place is probably before the last complex check.
rmarkdown::render("README.Rmd", output_format = "github_document")
unlink("README.html")
Sorry for not following up @pdrhlik . A hard and challenging week at work
pt., 28 wrz 2018 o 10:26 Patrik Drhlik notifications@github.com napisał(a):
Merged #16 https://github.com/pdrhlik/sweary/pull/16 into master.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pdrhlik/sweary/pull/16#event-1872938839, or mute the thread https://github.com/notifications/unsubscribe-auth/AGdazqXRJAiRUefNSKT8NW65zI0od36Zks5ufd08gaJpZM4Wwhqh .
No worries @MarcinKosinski. I think it was ready for the merge already. I needed it to check the Romanian words before merging it into master. But if you have any suggestions, spit them out! :-)
Because we need to have local tests to see if the language files are OK, we need a custom build mechanism.
This PR adds an unexported build_sweary() function for development purposes. It does several steps before the build. Namely:
swear_words
data frame with the newest added or modified language files.tests/testthat
(empty for now).This process should be used before any push. Only branches, PRs that pass this processed should be allowed to be merged into master.
Any suggestions, comments? @MarcinKosinski