search

pdrm83 / rotten_tomatoes_scraper

How to scrape the Rotten Tomatoes website and extract metadata from actor and movie pages.
MIT License
6 stars 3 forks source link

Add DirectorScraper #2

Closed dcarrano closed 3 years ago

dcarrano commented 3 years ago

Add DirectorScraper class. Similar to movie/celebrity, it can take the options "director_name" or "director_url". If the "print" option is set to "true", it will also print to console while it processes. The metadata returned consists of the movie title, year, RT score, and box office (in dollars) for each movie that the person directed.

pdrm83 commented 3 years ago

Thanks for your contribution. It was very well consistent with other parts. Please consider write tests in another PR as well. When you add tests, I will update the READEME.md. LGTM.

dcarrano commented 3 years ago

Sounds good. What speciifcally are you looking for?

pdrm83 commented 3 years ago

Sounds good. What speciifcally are you looking for?

Fantastic! I meant something similar to what you can see in the test_scraper.py