search

pds-data-dictionaries / PDS4-LDD-Issue-Repo

Issue repository for tracking all PDS4 Discipline Dictionary-related issues, new feature requests, and releases.
Apache License 2.0
2 stars 1 forks source link

[ldd-chan1] initial update needs for M3 #133

Closed thareUSGS closed 3 years ago

thareUSGS commented 3 years ago

Issue Type ENHANCEMENT

Describe the issue identified (if applicable) Initial needs for PDS3 to PDS4 migration for M3 (spectral instrument on chan1)

Describe the solution you'd like I think this is close to the complete list of attributes:

orbit_limb_direction

spacecraft_yaw_direction

[orientation model 1 -- these could be separate classes but do not necessarily need to be]

spacecraft_orientation

[orientation model 2]

spacecraft_orientation_rates

[orientation model 3]

spacecraft_orientation_axis_vector

spacecraft_rotation_rate

class: reference_orientation

initial_spacecraft_orientation

orientation_epoch_time

LDD Dictionary Version For bug fixes, note the LDD dictionary version in question.

PDS4 IM Version 1.F.0.0

thareUSGS commented 3 years ago

in branch v1100 I am confused by the need for spacecraft_rotation_rate as a single value and ALSO the need for Spacecraft_Orientation_Rates Class as a triplet. Perhaps just one is needed?

spacecraft_rotation_rate: https://github.com/pds-data-dictionaries/ldd-chan1/blob/896bc4a42a049a0b8994613d5b51253e33ef8096/src/PDS4_CHAN1_IngestLDD.xml#L291

Spacecraft_Orientation_Rates: https://github.com/pds-data-dictionaries/ldd-chan1/blob/896bc4a42a049a0b8994613d5b51253e33ef8096/src/PDS4_CHAN1_IngestLDD.xml#L583

thareUSGS commented 3 years ago

@m-stclair almost ready for a review. I think I need to drum an example using these classes and then we can iterate.

m-stclair commented 3 years ago

awesome! let me know when you want me to check them out.

m-stclair commented 3 years ago

on the spacecraft_rotation_rate vs. Spacecraft_Orientation_Rates issue: in one of the three orientation models the clementine data providers used, they recorded rate as a scalar, with the direction given by spacecraft_orientation_axis_vector. in the other, they recorded it as a vector. it's possible that there's some more elegant way to separate (or not separate) these values; the structure I outlined in that email basically just distinguishes the conventions of the three pointing models they provided. as no new pointing metadata of this type will ever be produced, strictly enforcing these conventions may not be necessary.

thareUSGS commented 3 years ago

@m-stclair updated branch schema a little to pull attributes out of orientation classes. Also added an example mapping that will be turned into a test. Are we close? https://github.com/pds-data-dictionaries/ldd-chan1/blob/1.1.0.0/test/M3G20090813T001943_V01_L1B.xml_partial

note the Classes with all "nil" could also just be removed.

m-stclair commented 3 years ago

@thareUSGS this looks great! even rolls in a few things from the PDS3 CH1 namespace that I had previously (acceptably but awkwardly) translated using msn, img, or proc. In the next day or two, I'll use it to make a couple test products, see if everything seems to be working cleanly, and get back to you. Thanks!

m-stclair commented 3 years ago

I have a couple of pattern fixes; other than that, everything works great. It seems like you automate LDD builds using a CI system I don't have access to. Do you want to me to just go ahead and submit the changes as a pull request that modifies a couple of the files in a development build, and then you can reference those to modify whatever source files you're using as necessary? Or I can just describe them -- whatever's easier.

thareUSGS commented 3 years ago

The trick to LDD build are to make a branch. If you don't access then you can still do a pull out just describe it. I can get a branch and CI. Either way. Thanks, Trent

-------- Original Message -------- From: m-stclair notifications@github.com Date: Sun, November 22, 2020 3:31 AM -0700 To: pds-data-dictionaries/PDS4-LDD-Issue-Repo PDS4-LDD-Issue-Repo@noreply.github.com CC: "Hare, Trent M" thare@usgs.gov, Mention mention@noreply.github.com Subject: [EXTERNAL] Re: [pds-data-dictionaries/PDS4-LDD-Issue-Repo] [ldd-chan1] initial update needs for M3 (#133)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

I have a couple of pattern fixes; other than that, everything works great. It seems like you automate LDD builds using a CI system I don't have access to. Do you want to me to just go ahead and submit the changes as a pull request that modifies a couple of the files in a development build, and then you can reference those to modify whatever source files you're using as necessary? Or I can just describe them -- whatever's easier.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpds-data-dictionaries%2FPDS4-LDD-Issue-Repo%2Fissues%2F133%23issuecomment-731727080&data=04%7C01%7Cthare%40usgs.gov%7C7d3527fffe844e242b3c08d88ed1c558%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416378897528806%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pjBS1tHQIDGbmLbgM4TNKJXNNpkAnGYYsoGeIg7TE9c%3D&reserved=0, or unsubscribehttps://gcc02.s %20afelinks %20.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAXTUYWME74VLRPR4WTXTOTSRDR7PANCNFSM4TJC6YOQ&data=04%7C01%7Cthare%40usgs.gov%7C228ea677897e417eb66508d88ed1c036%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416378808233810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3LPMAxQ4nJhAZBP%2BFEnYMvuyjqQ4V9Da4pz7Lom7Ruw%3D&reserved=0.

m-stclair commented 3 years ago

Ok, I'll make a branch. I assume the bot looks at https://github.com/pds-data-dictionaries/ldd-chan1/blob/1.1.0.0/src/PDS4_CHAN1_IngestLDD.xml in order to generate the .xsd. The schematron rules don't seem to be in there, though. What file do I modify to provide it with source for the .sch?

I'll also add a stub test label for each of the three attitude models.

thareUSGS commented 3 years ago

Michael, For whatever reason the PDS uses an even more abstracted version of the schema, which is what gets built by the PDS's LDDtool. Why - not sure. But when I took over the schemas from folks here, it took me a little bit to realize it. It was very confusing at first needing to build the schemas instead of just editing them... http://sbndev.astro.umd.edu/wiki/Creating_the_Ingest_LDD_Dictionary_Input_File

BTW, this is a thing in XML (not just made up by the PDS).

So, yes the only file needing changing (readme aside), is PDS4_CHAN1_IngestLDD.xml

It is fine to offer schema updates, I can back-port them to LDDs.

-Trent

From: m-stclair notifications@github.com Sent: Sunday, November 22, 2020 12:51 PM To: pds-data-dictionaries/PDS4-LDD-Issue-Repo PDS4-LDD-Issue-Repo@noreply.github.com Cc: Hare, Trent M thare@usgs.gov; Mention mention@noreply.github.com Subject: [EXTERNAL] Re: [pds-data-dictionaries/PDS4-LDD-Issue-Repo] [ldd-chan1] initial update needs for M3 (#133)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

Ok, I'll make a branch. I assume the bot looks at https://github.com/pds-data-dictionaries/ldd-chan1/blob/1.1.0.0/src/PDS4_CHAN1_IngestLDD.xmlhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpds-data-dictionaries%2Fldd-chan1%2Fblob%2F1.1.0.0%2Fsrc%2FPDS4_CHAN1_IngestLDD.xml&data=04%7C01%7Cthare%40usgs.gov%7Cc763de49a42b40d25fa108d88f201aea%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416715348411823%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=O4iDc6WtOFb0ao55fR2YzRDnC8RkP7Ux9c7GVlfQk0U%3D&reserved=0 in order to generate the .xsd. The schematron rules don't seem to be in there, t hough. What file do I modify to provide it with source for the .sch?

I'll also add a stub test label for each of the three attitude models.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpds-data-dictionaries%2FPDS4-LDD-Issue-Repo%2Fissues%2F133%23issuecomment-731835313&data=04%7C01%7Cthare%40usgs.gov%7Cc763de49a42b40d25fa108d88f201aea%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416715348411823%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aIEEpSDoENN%2BQXRoTLh7gkGBRI6TNVB%2BVNqBuEHZj9E%3D&reserved=0, or unsubscribehttps://gcc02.saf %20elinks.p %20rotection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAXTUYSFDTQBC4MDPPYJ63DSRFTTVANCNFSM4TJC6YOQ&data=04%7C01%7Cthare%40usgs.gov%7Cb97f99147f234199737908d88f1ffd44%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416714850233822%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GPjG%2BeE9h4J81cpLlzTZq6TbRITlQxi6h2V6m7xIy%2BI%3D&reserved=0.

m-stclair commented 3 years ago

XML is complicated!

Ok, now I see the line in PDS4_CHAN1_IngestLDD.xml that generates the schematron rule of concern. I will go ahead and submit a pull request with these minor changes later today. Thanks!

On Sun, Nov 22, 2020 at 8:10 PM Trent Hare notifications@github.com wrote:

Michael, For whatever reason the PDS uses an even more abstracted version of the schema, which is what gets built by the PDS's LDDtool. Why - not sure. But when I took over the schemas from folks here, it took me a little bit to realize it. It was very confusing at first needing to build the schemas instead of just editing them...

http://sbndev.astro.umd.edu/wiki/Creating_the_Ingest_LDD_Dictionary_Input_File

BTW, this is a thing in XML (not just made up by the PDS).

So, yes the only file needing changing (readme aside), is PDS4_CHAN1_IngestLDD.xml

It is fine to offer schema updates, I can back-port them to LDDs.

-Trent

From: m-stclair notifications@github.com Sent: Sunday, November 22, 2020 12:51 PM To: pds-data-dictionaries/PDS4-LDD-Issue-Repo < PDS4-LDD-Issue-Repo@noreply.github.com> Cc: Hare, Trent M thare@usgs.gov; Mention mention@noreply.github.com Subject: [EXTERNAL] Re: [pds-data-dictionaries/PDS4-LDD-Issue-Repo] [ldd-chan1] initial update needs for M3 (#133)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

Ok, I'll make a branch. I assume the bot looks at https://github.com/pds-data-dictionaries/ldd-chan1/blob/1.1.0.0/src/PDS4_CHAN1_IngestLDD.xml < https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpds-data-dictionaries%2Fldd-chan1%2Fblob%2F1.1.0.0%2Fsrc%2FPDS4_CHAN1_IngestLDD.xml&data=04%7C01%7Cthare%40usgs.gov%7Cc763de49a42b40d25fa108d88f201aea%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416715348411823%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=O4iDc6WtOFb0ao55fR2YzRDnC8RkP7Ux9c7GVlfQk0U%3D&reserved=0> in order to generate the .xsd. The schematron rules don't seem to be in there, t hough. What file do I modify to provide it with source for the .sch?

I'll also add a stub test label for each of the three attitude models.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub< https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpds-data-dictionaries%2FPDS4-LDD-Issue-Repo%2Fissues%2F133%23issuecomment-731835313&data=04%7C01%7Cthare%40usgs.gov%7Cc763de49a42b40d25fa108d88f201aea%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416715348411823%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aIEEpSDoENN%2BQXRoTLh7gkGBRI6TNVB%2BVNqBuEHZj9E%3D&reserved=0>, or unsubscribe<https://gcc02.saf %20elinks.p % 20rotection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAXTUYSFDTQBC4MDPPYJ63DSRFTTVANCNFSM4TJC6YOQ&data=04%7C01%7Cthare%40usgs.gov%7Cb97f99147f234199737908d88f1ffd44%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416714850233822%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GPjG%2BeE9h4J81cpLlzTZq6TbRITlQxi6h2V6m7xIy%2BI%3D&reserved=0

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/133#issuecomment-731839780, or unsubscribe https://github.com/notifications/unsubscribe-auth/APIXBZJZJPOXJDG366HPNZTSRFV3VANCNFSM4TJC6YOQ .

m-stclair commented 3 years ago

and, unfortunately, it looks like I don't have permission to submit pull requests to this repo. can you add me as a collaborator?

On Sun, Nov 22, 2020 at 8:18 PM Michael St. Clair < mstclair@millionconcepts.com> wrote:

XML is complicated!

Ok, now I see the line in PDS4_CHAN1_IngestLDD.xml that generates the schematron rule of concern. I will go ahead and submit a pull request with these minor changes later today. Thanks!

On Sun, Nov 22, 2020 at 8:10 PM Trent Hare notifications@github.com wrote:

Michael, For whatever reason the PDS uses an even more abstracted version of the schema, which is what gets built by the PDS's LDDtool. Why - not sure. But when I took over the schemas from folks here, it took me a little bit to realize it. It was very confusing at first needing to build the schemas instead of just editing them...

http://sbndev.astro.umd.edu/wiki/Creating_the_Ingest_LDD_Dictionary_Input_File

BTW, this is a thing in XML (not just made up by the PDS).

So, yes the only file needing changing (readme aside), is PDS4_CHAN1_IngestLDD.xml

It is fine to offer schema updates, I can back-port them to LDDs.

-Trent

From: m-stclair notifications@github.com Sent: Sunday, November 22, 2020 12:51 PM To: pds-data-dictionaries/PDS4-LDD-Issue-Repo < PDS4-LDD-Issue-Repo@noreply.github.com> Cc: Hare, Trent M thare@usgs.gov; Mention mention@noreply.github.com Subject: [EXTERNAL] Re: [pds-data-dictionaries/PDS4-LDD-Issue-Repo] [ldd-chan1] initial update needs for M3 (#133)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

Ok, I'll make a branch. I assume the bot looks at https://github.com/pds-data-dictionaries/ldd-chan1/blob/1.1.0.0/src/PDS4_CHAN1_IngestLDD.xml < https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpds-data-dictionaries%2Fldd-chan1%2Fblob%2F1.1.0.0%2Fsrc%2FPDS4_CHAN1_IngestLDD.xml&data=04%7C01%7Cthare%40usgs.gov%7Cc763de49a42b40d25fa108d88f201aea%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416715348411823%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=O4iDc6WtOFb0ao55fR2YzRDnC8RkP7Ux9c7GVlfQk0U%3D&reserved=0> in order to generate the .xsd. The schematron rules don't seem to be in there, t hough. What file do I modify to provide it with source for the .sch?

I'll also add a stub test label for each of the three attitude models.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub< https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpds-data-dictionaries%2FPDS4-LDD-Issue-Repo%2Fissues%2F133%23issuecomment-731835313&data=04%7C01%7Cthare%40usgs.gov%7Cc763de49a42b40d25fa108d88f201aea%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416715348411823%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aIEEpSDoENN%2BQXRoTLh7gkGBRI6TNVB%2BVNqBuEHZj9E%3D&reserved=0>, or unsubscribe<https://gcc02.saf %20elinks.p % 20rotection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAXTUYSFDTQBC4MDPPYJ63DSRFTTVANCNFSM4TJC6YOQ&data=04%7C01%7Cthare%40usgs.gov%7Cb97f99147f234199737908d88f1ffd44%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416714850233822%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GPjG%2BeE9h4J81cpLlzTZq6TbRITlQxi6h2V6m7xIy%2BI%3D&reserved=0

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/133#issuecomment-731839780, or unsubscribe https://github.com/notifications/unsubscribe-auth/APIXBZJZJPOXJDG366HPNZTSRFV3VANCNFSM4TJC6YOQ .

m-stclair commented 3 years ago

great, thank you, submitted.

On Sun, Nov 22, 2020 at 9:57 PM Michael St. Clair < mstclair@millionconcepts.com> wrote:

and, unfortunately, it looks like I don't have permission to submit pull requests to this repo. can you add me as a collaborator?

On Sun, Nov 22, 2020 at 8:18 PM Michael St. Clair < mstclair@millionconcepts.com> wrote:

XML is complicated!

Ok, now I see the line in PDS4_CHAN1_IngestLDD.xml that generates the schematron rule of concern. I will go ahead and submit a pull request with these minor changes later today. Thanks!

On Sun, Nov 22, 2020 at 8:10 PM Trent Hare notifications@github.com wrote:

Michael, For whatever reason the PDS uses an even more abstracted version of the schema, which is what gets built by the PDS's LDDtool. Why - not sure. But when I took over the schemas from folks here, it took me a little bit to realize it. It was very confusing at first needing to build the schemas instead of just editing them...

http://sbndev.astro.umd.edu/wiki/Creating_the_Ingest_LDD_Dictionary_Input_File

BTW, this is a thing in XML (not just made up by the PDS).

So, yes the only file needing changing (readme aside), is PDS4_CHAN1_IngestLDD.xml

It is fine to offer schema updates, I can back-port them to LDDs.

-Trent

From: m-stclair notifications@github.com Sent: Sunday, November 22, 2020 12:51 PM To: pds-data-dictionaries/PDS4-LDD-Issue-Repo < PDS4-LDD-Issue-Repo@noreply.github.com> Cc: Hare, Trent M thare@usgs.gov; Mention mention@noreply.github.com Subject: [EXTERNAL] Re: [pds-data-dictionaries/PDS4-LDD-Issue-Repo] [ldd-chan1] initial update needs for M3 (#133)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

Ok, I'll make a branch. I assume the bot looks at https://github.com/pds-data-dictionaries/ldd-chan1/blob/1.1.0.0/src/PDS4_CHAN1_IngestLDD.xml < https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpds-data-dictionaries%2Fldd-chan1%2Fblob%2F1.1.0.0%2Fsrc%2FPDS4_CHAN1_IngestLDD.xml&data=04%7C01%7Cthare%40usgs.gov%7Cc763de49a42b40d25fa108d88f201aea%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416715348411823%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=O4iDc6WtOFb0ao55fR2YzRDnC8RkP7Ux9c7GVlfQk0U%3D&reserved=0> in order to generate the .xsd. The schematron rules don't seem to be in there, t hough. What file do I modify to provide it with source for the .sch?

I'll also add a stub test label for each of the three attitude models.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub< https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpds-data-dictionaries%2FPDS4-LDD-Issue-Repo%2Fissues%2F133%23issuecomment-731835313&data=04%7C01%7Cthare%40usgs.gov%7Cc763de49a42b40d25fa108d88f201aea%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416715348411823%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aIEEpSDoENN%2BQXRoTLh7gkGBRI6TNVB%2BVNqBuEHZj9E%3D&reserved=0>, or unsubscribe<https://gcc02.saf %20elinks.p % 20rotection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAXTUYSFDTQBC4MDPPYJ63DSRFTTVANCNFSM4TJC6YOQ&data=04%7C01%7Cthare%40usgs.gov%7Cb97f99147f234199737908d88f1ffd44%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637416714850233822%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GPjG%2BeE9h4J81cpLlzTZq6TbRITlQxi6h2V6m7xIy%2BI%3D&reserved=0

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/133#issuecomment-731839780, or unsubscribe https://github.com/notifications/unsubscribe-auth/APIXBZJZJPOXJDG366HPNZTSRFV3VANCNFSM4TJC6YOQ .

thareUSGS commented 3 years ago

push release to EN node.