search

pds-data-dictionaries / PDS4-LDD-Issue-Repo

Issue repository for tracking all PDS4 Discipline Dictionary-related issues, new feature requests, and releases.
Apache License 2.0
2 stars 1 forks source link

[ldd-img_surface] Need new valid for geometry_projection_type #155

Closed rgdeen closed 3 years ago

rgdeen commented 3 years ago

Need a new valid value for geometry_projection type. Currently it supports Raw, Linearized, and None. New value:

Trapezoid: Trapezoidal reprojection, used to compensate for an off-axis camera such as the Mars 2020 PIXL MCC.

Yes, in the multimission dictionaries. This type of correction could be used on other instruments too that look off-axis.

thareUSGS commented 3 years ago

@rgdeen When adding Trapezoid, I notice there is no "None". I assume "Raw" is meant to be used for "None" or do you want me to add "None" as an option?

RAW - Indicates the image has not been reprojected. The original camera model is still in use.

thareUSGS commented 3 years ago

Updated one Trapezoid (did not include "None"). In this branch for testing: https://github.com/pds-data-dictionaries/ldd-img_surface/tree/release/1.16.0.0

or dev builds: https://github.com/pds-data-dictionaries/ldd-img_surface/tree/release/1.16.0.0/build/development/

rgdeen commented 3 years ago

We need raw. None is generally good to have on general principle although in this case that’s pretty much synonymous with raw.

Which is a long winded way of saying I don’t have a strong opinion here. ;-)

-Bob

Sent from my iPhone

On May 10, 2021, at 10:04 AM, Trent Hare @.**@.>> wrote:

@rdgeen When adding Trapezoid, I notice the is no "None". I assume "Raw" is meant to be used for "None" or do you want me to add "None" as an option?

RAW - Indicates the image has not been reprojected. The original camera model is still in use.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/155*issuecomment-836974518__;Iw!!PvBDto6Hs4WbVuu7!eJg5nVREoW47hEzmpJeizao1tLzYdwRKoaSIJUS05t8Z9_WPo0BeyMP5--HyIeinRplg$, or unsubscribehttps://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AB5QEOK2OJ67OZMEJSPVMBTTNAGYJANCNFSM44QHCHTQ__;!!PvBDto6Hs4WbVuu7!eJg5nVREoW47hEzmpJeizao1tLzYdwRKoaSIJUS05t8Z9_WPo0BeyMP5--HyITL60J6M$.

thareUSGS commented 3 years ago

leaving None out for now. We can add later if needed. closing.