[ldd-disp] build failure for v1600 I can't resolve

[thareUSGS]

Issue Type Validation build failure seems like it should be easy but can't figure out a fix.

Describe the issue identified (if applicable) "Variable pds:local_identifier_reference has not been declared" see build logs: https://github.com/pds-data-dictionaries/ldd-disp/blob/v1600/logs/v1.16.0.0_execution_logs/validate_report_20220504172621.txt

Describe the solution you'd like Maybe help check out ingestLDD for issues

LDD Dictionary Version v1600 branch.

PDS4 IM Version All

[acraugh]

I suspect a typo, and probably a particularly dumb one because it sounds like something I did myself at least twice. I'll investigate shortly...

-Anne.

On Wed, May 4, 2022 at 2:23 PM Trent Hare @.***> wrote:

Assigned #214 https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/214 to @acraugh https://github.com/acraugh.

— Reply to this email directly, view it on GitHub https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/214#event-6550784270, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBV2QFRQ2XMBU2WQC54IPTVIK6C3ANCNFSM5VCZCSJQ . You are receiving this because you were assigned.Message ID: <pds-data-dictionaries/PDS4-LDD-Issue-Repo/issue/214/issue_event/6550784270 @github.com>

[acraugh]

@thareUSGS, I pushed a fix to the v1600 branch - the '$' in the beginning of "$pds:local_identifier_reference" was the typo, so I removed it in both places it occurred. My test build at home worked, but the build in the repo failed because of the resource limits on the repos. I gather the reset period is an hour. I'd fix it in the dmsp-test branch as well, except that would just reset the time-out clock. (That's what I get for propagating bells & whistles late in the evening!)

Since you're in the more westerly time zone, I leave it to you to attempt a repo build again. If there are further difficulties, let me know. I'll leave this open just in case...

[thareUSGS]

@acraugh Great - good find. That should fix it.

Unfortunately, "build" is having an unrelated issue (looks like a configuration action issue or perhaps something else I did). @jordanpadams -- sorry I might need your help on this. CART is also having the same log path error now in a recently updated branch.

Error: Path does not exist /home/runner/work/ldd-disp/ldd-disp/logs https://github.com/pds-data-dictionaries/ldd-disp/runs/6296426852?check_suite_focus=true

the path is now "/dd-disp/ldd-disp/" (which should just be one not a ldd-disp repeat).

[jordanpadams]

@thareUSGS see the email I just regarding the rate limit error you are seeing