pds-data-dictionaries / PDS4-LDD-Issue-Repo

Issue repository for tracking all PDS4 Discipline Dictionary-related issues, new feature requests, and releases.
Apache License 2.0
2 stars 1 forks source link

[ldd-ml] Require Test_Set if Test_Performance is specified #233

Open wkiri opened 2 years ago

wkiri commented 2 years ago

Describe the issue identified Values in Test_Performance only make sense if there is also a Test_Set specified. However, since both Test_Performance and Test_Set are optional, there could be a case where Test_Performance is included but not Test_Set.

Describe the solution you'd like A Schematron rule is one way to require that Test_Set is present if Test_Performance is included.

Describe alternatives you've considered Another idea is to include Performance as an attribute under Test_Set. However, this would probably mean making it part of the super-class Data_Set which means it would also be available for Training_Set and Validation_Set. This might actually be useful for anyone who wants to report performance on these data sets as well. Worth discussing with Steven Lu.

LDD Dictionary Version 1.0.1.0

PDS4 IM Version 1.18.0.0

Need-by Date When convenient.

Additional context None.