pds-data-dictionaries / PDS4-LDD-Issue-Repo

Issue repository for tracking all PDS4 Discipline Dictionary-related issues, new feature requests, and releases.
Apache License 2.0
2 stars 1 forks source link

[ldd-clipper] Add a new element encounter_id #248

Closed seanhardman closed 7 months ago

seanhardman commented 1 year ago

Issue Type This is an enhancement for the ldd-clipper mission dictionary.

Describe the issue identified (if applicable) Along with orbit_number, the Europa Clipper mission has identified encounter as a meaningful attribute for data identification.

Describe the solution you'd like Add a new element to the dictionary named _encounterid that does not have a distinct value set but has the following meaning:

Initial Definition

Updated Definition

Describe alternatives you've considered N/A

LDD Dictionary Version N/A

PDS4 IM Version N/A

Need-by Date Summer 2023

Additional context N/A

matthewtiscareno commented 1 year ago

I see that there is a "XXX" value for "no encounter," but it seems that it is not used except before JOI and after the final encounter of the prime mission (since an encounter does not end until the beginning of the next encounter).

This means that a data product might be obtained several orbits after the most recent encounter, having nothing to do with that encounter, but this attribute would mark it as being part of that most recent encounter rather than part of "XXX." Is that the intention?

seanhardman commented 1 year ago

Upon further investigation of the Mission Plan, the original definition of an encounter above is pretty spot on to how the encounters in the plan are defined starting with the first encounter with Ganymede (G00). From that point forward, encounters run back-to-back throughout the tour, including through the campaign transitions (I was mistaken about this at the DAWG). So, Matt's concern above is a reality where an encounter spans multiple orbits. It only happens in a handful of cases and they are mostly in the transitions. There are a couple of encounters in the current plan that span 3 orbits until the next encounter.

I do plan on tweaking the element definition above to point out that "XXX" will be used during cruise up until the first encounter. I also plan to nix the sentence about gravity assist values since they are not officially in the mission plan (at least for now).

thareUSGS commented 11 months ago

Please review PR: https://github.com/pds-data-dictionaries/ldd-clipper/pull/6