Closed rgdeen closed 1 year ago
@rgdeen for img:processing_venue Onboard_Camera, can we just use the existing "Onboard Hardware" instead of adding a new value?
<DD_Permissible_Value>
<value>Onboard Hardware</value>
<value_meaning>Processing was done by hardware onboard the spacecraft,
such as inside the camera.</value_meaning>
</DD_Permissible_Value>
Also, processing_algorithm is free text (not enumerated). Thus currently you can list whatever you need.
what PDS4 information model version do you need? I am only building 1.16.0.0 - 1.21.0.0 which is really more than I really want to.
New build version to review and test with White_Balance Class and new attribute white_balance_color_temp: (updated): https://github.com/pds-data-dictionaries/ldd-img/tree/release/1.21.0.0/build/development/96ac91f75d2ac579929438ef04e3559f7731ae18
@thareUSGS I haven't decided on an IM version for CADRE yet, so I don't see any reason not to use the most current one.
These updates should be officially released. Feel free to re-open this if not. https://pds.nasa.gov/datastandards/dictionaries/index-1.21.0.0.shtml#img
Issue Type Enhancement
Describe the issue identified (if applicable) Missions are using more and more COTS cameras. Some of these have processing built in that needs to be identified in the label. In this case, the SACA camera for CADRE can do onboard white balance.
Describe the solution you'd like White_Balance - subclass of Data Processing, child of Color_Processing. Definition: Indicates what processing was used for white balance either onboard or on the ground.
Attrributes: white_balance_color_temp - real, card 0:1, unit 'K'. Definition: The color temperature used to white-balance the image.
Note that the Data_Processing base class has active_flag and processing_venue which would be used here (and processing_algorithm if needed).
In the case at hand (CADRE) I propose these VICAR labels: WHITE_BALANCE = ON | OFF WHITE_BALANCE_VENUE = ONBOARD_CAMERA WHITE_BALANCE_METHOD = NONE | CAMERA_AUTO | CAMERA_MANUAL WHITE_BALANCE_COLOR_TEMP = 3000. (__UNIT = K)
which would translate as follows:
Camera_Auto and Camera_Manual are intended to indicate whatever also is onboard the camera (users would have to look at the camera docs for more - sometimes this info is proprietary; in this case I have no idea what they're doing... but it still needs to be documented that it's turned on or off and what the parameters are). Auto or Manual means what settings are used (in this case, whether we specify the color temp or it figures it out).
Describe alternatives you've considered none
LDD Dictionary Version n/a
PDS4 IM Version whatever is latest
Need-by Date I need to know if this approach is acceptable by end of Nov (so I can change the vicar labels if needed). I won't need it actually in the DD until spring 2024 (flexible).
Additional context nope