pds-data-dictionaries / PDS4-LDD-Issue-Repo

Issue repository for tracking all PDS4 Discipline Dictionary-related issues, new feature requests, and releases.
Apache License 2.0
2 stars 1 forks source link

[ldd-ebt] Please add heliocentric and geocentric distance for the target (object) #295

Open beatricemueller opened 3 months ago

beatricemueller commented 3 months ago

Issue Type Using the LABELS section to the right of this window >>>> , please indicate if this is a BUG or ENHANCEMENT request. If unknown, feel free to leave that blank and the LDD Steward can triage appropriately.

Describe the issue identified (if applicable) Heliocentric and geocentric distances exist in the geometry dictionary but they are under Geometry_Orbiter/Distance/Distance_Specific. This does not apply to EB telescope observations as there is no orbiter around the observed target.

Describe the solution you'd like A clear and concise description of what you want to happen. Where possible please include details like:

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

LDD Dictionary Version For bug fixes, note the LDD dictionary version in question.

PDS4 IM Version For new feature requests, please note the PDS4 Information Model version you would like the new feature implemented against.

Need-by Date Describe a need-by date for these updates and the rationale for that date. ASAP

Additional context Add any other context or examples products Description: The object_heliocentricdistance attribute provides the scalar distance between the center of the object and the center of the Sun. (Or use target instead of object, although target... is already in the geometry dictionary). Should be optional but not nillable, unit should be AU.

matthewtiscareno commented 3 months ago

Would it be better for the Distances_Specific class that's already in the Geometry LDD to be exposed in such a way that it could be incorporated into an appropriate class within the EBT LDD?

beatricemueller commented 3 months ago

@matthewtiscareno: How would you do that? The problem is that the distances in geom seem to be tied to spacecraft/landers (orbiter, surface). If you can come up with something feasible, I would be happy to entertain that. Either way, it seems that something has to be added somewhere, either in geom or EBT.

matthewtiscareno commented 3 months ago

The Geometry LDD includes attributes target_geocentric_distance and target_heliocentric_distance. Isn't that what you want?

If you confirm that I understand correctly, then as the steward of this portion of the Geometry LDD, I would volunteer to start a conversation with EN about whether these attributes can be reused and incorporated into the EBT LDD, rather than copied.

beatricemueller commented 3 months ago

Yes, that is what I want but it is under Geometry_Orbiter/Distance/Distance_Specific. There is no orbiter for groundbased observations and is not appropriate for those observations.

matthewtiscareno commented 3 months ago

Yes, I understand that. The issue here is that the attribute has general applicability and has been put into a class that is too specific.

I'd like to confer with some people to consider how to supply what you need here. What is the timescale on which you need this functionality?

matthewtiscareno commented 3 months ago

P.S. In case people try a text search in the LDD to find what we're discussing, it's actually Geometry_Orbiter/Distances/Distances_Specific.

beatricemueller commented 3 months ago

A provider needs this now in order to get the info into the label.

beatricemueller commented 3 months ago

I am happy to have this in geom as long as it is not tied to spacecraft. It does not have to be at EBT

benjhirsch commented 3 months ago

I'd like to confer with some people to consider how to supply what you need here. What is the timescale on which you need this functionality?

As the EBT steward and someone who makes use of the Geometry dictionary quite frequently, please keep me in the loop regarding implementation. If it looks like it's going to be tricky or take awhile, I can always make an addition to the EBT dictionary as originally requested.

beatricemueller commented 2 months ago

As I understand they were some discussions. Can we please get to a solution soon.

matthewtiscareno commented 2 months ago

Right you are, @beatricemueller.

Hey @jmafi, could we please put CCB#41 at our near the top of the agenda when we have our next DDWG meeting on Thursday 10/3?