search

pds-data-dictionaries / ldd-nh

Attributes used for mission-specific metadata in the New Horizons primary mission and extended missions to Kuiper Belt Objects.
Apache License 2.0
0 stars 0 forks source link

Add spacecraft state information and Ralph/LEISA details #12

Closed cgobat closed 3 months ago

cgobat commented 4 months ago

Summary

Adds Spacecraft_State, LEISA_Details, and Ralph_Details classes, plus associated attributes.

NOTE: this PR's source branch builds on the proposed-changes branch, and should only be merged after #11 so as to avoid weirdness.

Test Data and/or Report

The Spacecraft_State class has been added to the existing MVIC test labels (see 91b2e94), and everything builds/passes as expected.

Related Issues

Builds on pull request #11. Other than that, no associated issues.

acraugh commented 3 months ago

Yes. I'll merge them in that order, but I don't see any reference to LEISA in the document updates in either branch. I'm wondering how they are going to spontaneously appear. Did I miss something? Or maybe there are no actual LEISA classes yet, and thus nothing to mock up...

-Anne.

On Thu, Mar 28, 2024 at 6:10 PM Caden Gobat @.***> wrote:

@.**** commented on this pull request.

On docs/source/detailed/outline.rst https://github.com/pds-data-dictionaries/ldd-nh/pull/12#discussion_r1543783417 :

The way I did these two PRs is a little weird in that this one branches off of #11 https://github.com/pds-data-dictionaries/ldd-nh/pull/11, so all of #11 https://github.com/pds-data-dictionaries/ldd-nh/pull/11's changes are here as well. When #11 https://github.com/pds-data-dictionaries/ldd-nh/pull/11 gets merged, it will work out and then only the new stuff here will appear in the change set.

— Reply to this email directly, view it on GitHub https://github.com/pds-data-dictionaries/ldd-nh/pull/12#discussion_r1543783417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBV2QEC64N7NCZKBN7G4PTY2SIM5AVCNFSM6AAAAABEFYGJF2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRXGQ2TGNBWGI . You are receiving this because your review was requested.Message ID: @.***>

cgobat commented 3 months ago

Right, I was just pointing out that most of your comments along the lines of " $x$ again"/"another $x$" aren't actually another occurrence of $x$.

acraugh commented 3 months ago

@cgobat , PR #12 looks good to merge into the fixup branch. Was there anything else you wanted to add/change before that?

cgobat commented 3 months ago

Nope, should be good to go. Thanks!