Closed cgobat closed 4 months ago
@acraugh identified some conflicts/issues to be resolved prior to merging this.
The only "Unresolved" ones that I identified as in-scope/applicable to this pull request were
<detector_name>
list of permissible values.
<pivot_wavelength>
: urn:nasa:pds:nh_documents:mission:soc_inst_icd
vs. urn:nasa:pds:nh_doc:all:soc_inst_icd
So I think this should be mergeable—let me know if you disagree. We can discuss the other items in the spreadsheet on another ticket.
cc @benjhirsch
Roger that. Thanks for making time for this. I think questions/requests for clarification/docs are probably best referred to Adeline—none of the Alice content here is mine.
Ah, right. I'll mention it specifically in tomorrow's local meeting, then. I expect it's in the ICD somewhere...
Summary
Adds Adeline's Alice stuff and Ben's LORRI stuff. I first merged the
alice+lorri_classes
branch intoresolve_conflicts
, to allow me to perform the required conflict resolution. Now this PR serves to mergeresolve_conflicts
into main.Test Data and/or Report
See CI run #40 and logs.
Related Issues
16
19
23
24