pds-data-dictionaries / ldd-nh

Attributes used for mission-specific metadata in the New Horizons primary mission and extended missions to Kuiper Belt Objects.
Apache License 2.0
0 stars 0 forks source link

Integrate SBN's Alice & LORRI additions #25

Closed cgobat closed 4 months ago

cgobat commented 4 months ago

Summary

Adds Adeline's Alice stuff and Ben's LORRI stuff. I first merged the alice+lorri_classes branch into resolve_conflicts, to allow me to perform the required conflict resolution. Now this PR serves to merge resolve_conflicts into main.

Test Data and/or Report

See CI run #40 and logs.

Related Issues

cgobat commented 4 months ago

@acraugh identified some conflicts/issues to be resolved prior to merging this.

The only "Unresolved" ones that I identified as in-scope/applicable to this pull request were

So I think this should be mergeable—let me know if you disagree. We can discuss the other items in the spreadsheet on another ticket.

cc @benjhirsch

cgobat commented 4 months ago

Roger that. Thanks for making time for this. I think questions/requests for clarification/docs are probably best referred to Adeline—none of the Alice content here is mine.

acraugh commented 4 months ago

Ah, right. I'll mention it specifically in tomorrow's local meeting, then. I expect it's in the ICD somewhere...