pdsinterop / community-server

Community Solid Server: an open and modular implementation of the Solid specifications
MIT License
3 stars 1 forks source link

Add WAC tests in github actions #21

Open michielbdejong opened 1 year ago

michielbdejong commented 1 year ago

With https://github.com/pdsinterop/community-server/pull/20 the test/surface/run-solid-test-suite.sh script will run in github actions, but that script is now only running the solid-CRUD-tests. It should also run the Web-Access-Control-tests.

@mrvahedi68 yesterday you said:

I tried many things to pass web access control tests but all of them failed.

Can you write a comment on this issue detailing which things you tried and how they failed?

mrvahedi68 commented 1 year ago

I checked out web-access-control-test from run-against-css branch and after starting CSS with npm start on port 3000 called ./run-against-css.sh from WAC.

Result: Failed all tests

mrvahedi68 commented 1 year ago

Created a sh file and replaced with run-against-css.sh in WAC with this configs:

    #!/bin/bash
    set -e
    export WEBID_ALICE=http://localhost:3000/profile/card#me
    export OIDC_ISSUER_ALICE=http://localhost:3000
    export STORAGE_ROOT_ALICE=http://localhost:3000/
    export WEBID_BOB=http://localhost:30001/profile/card#me
    export OIDC_ISSUER_BOB=http://localhost:30001
    export STORAGE_ROOT_BOB=http://localhost:30001/

Result: Failed all tests.

mrvahedi68 commented 1 year ago

Cloned NSS and ran it and called the default run-against-css.sh from WAC with one difference for replacing HELP_SERVER_HOST=solidcommunity.net with HELP_SERVER_HOST=localhost:8443.

Result: Failed all tests.

mrvahedi68 commented 1 year ago

Ran NSS with docker and map 443 port from container to host, then replaced HELP_SERVER_HOST=solidcommunity.net with HELP_SERVER_HOST=localhost.

Result: Failed all tests

mrvahedi68 commented 1 year ago

Comment out line 16 of ./node_modules/@solid/access-token-verifier/dist/algorithm/verifySolidAccessTokenIssuer.js for this issue. then ran with solidcommunity.net help server.

Result: All tests failed.

mrvahedi68 commented 1 year ago

going to run tests again with online NSS.

mrvahedi68 commented 1 year ago

Check for existing https://tester as trusted app for this users:

mrvahedi68 commented 1 year ago

WAC tests passing with one failing:

Screen Shot 1402-06-13 at 00 40 42

mrvahedi68 commented 1 year ago

Related PR: https://github.com/pdsinterop/community-server/pull/22 @michielbdejong

mrvahedi68 commented 1 year ago

new issue for failing test: https://github.com/pdsinterop/community-server/issues/23