search

pdtpartners / nix-snapshotter

Brings native understanding of Nix packages to containerd
MIT License
532 stars 15 forks source link

fixes nix builder #107

Closed antoinerg closed 8 months ago

antoinerg commented 8 months ago

As far as I can tell, the following feature advertised in the README.md isn't working:

Packages can be fetched from a binary cache or built on the fly if necessary.

This PR resolves this!

RobbieBuxton commented 8 months ago

Ah good spot! looks like a typo to me. I've checked it doesn't break anything on my machine so should be good for merge @elpdt852!

antoinerg commented 8 months ago

I don’t understand how this slipped through integration tests… good catch. I’ll have to investigate why it went unnoticed.

@elpdt852 I think it is because the integration tests preload the VM with the images so the nix store is already populated!