search

pdtpartners / nix-snapshotter

Brings native understanding of Nix packages to containerd
MIT License
532 stars 15 forks source link

k3s: use default buildGoModule #138

Closed ck3d closed 4 months ago

ck3d commented 4 months ago

buildGo120Module is not available for NixOS 24.05

RobbieBuxton commented 4 months ago

@ck3d this seems to break the k3s integration tests? (it doesn't appear to be starting properly). Do you have a link to the PR/Commit where they remove buildGo120Module by any chance, I had a look but couldn't find anything. I wouldn't mind reading into it a little bit more.

RobbieBuxton commented 4 months ago

I just double checked that it's not our CI that's broken, I managed to replicate the errors on my machine. If you try any ofnix run .#test-k3s-rootless, nix run .#test-k3s-external or nix run .#test-k3s you should be able to reproduce the error.

RobbieBuxton commented 4 months ago

I'm pretty sure the bug is this. I suspect this is why we were building with Go120 in the first place? I might pull @elpdt852 in on this one.

The solution AUR seems to be using is to cherry pick this PR

elpdt852 commented 4 months ago

@RobbieBuxton thanks for root causing this. That looks correct, see if you can use fetchpatch to simply apply the patch from GitHub's API: https://patch-diff.githubusercontent.com/raw/k3s-io/k3s/pull/9064.patch

ck3d commented 4 months ago

Go 1.20 was removed with https://github.com/NixOS/nixpkgs/pull/295077

I can confirm, the tests fail. So, I close this PR.

RobbieBuxton commented 4 months ago

I'll have a go at switching it over, thanks for the heads up @ck3d much appreciated!