search

pdtpartners / nix-snapshotter

Brings native understanding of Nix packages to containerd
MIT License
532 stars 15 forks source link

add aarch64 to systems #140

Open yu-re-ka opened 3 months ago

yu-re-ka commented 3 months ago

This allows nix run .#vm and nix run .#vm-rootless to work on aarch64-linux systems such as Apple Silicon Macs

RobbieBuxton commented 3 months ago

Thanks for the contribution @yu-re-ka! Just to double check, I assume you've verified locally this works on Apple Silicon?

yu-re-ka commented 3 months ago

Ran the following tests successfully:

Failing tests:

on aarch64-linux

RobbieBuxton commented 3 months ago

I think there is an issue with the test runners atm, but I verified all the tests are still passing for x86 on my machine. It might be a good idea to have a table on the README showing support for different platforms now that we have more than one (i.e no gvisor or k3s on Apple Silicon) @elpdt852? Otherwise happy to merge!

yu-re-ka commented 3 months ago

nix run .#vm does work out of the box

14 Jun 2024 02:51:59 Edgar Lee @.***>:

@.**** commented on this pull request.

In modules/nixos/default.nix[https://github.com/pdtpartners/nix-snapshotter/pull/140#discussion_r1639083816]:

@@ -64,8 +64,10 @@ in {


*/
flake.nixosConfigurations = {
-    vm = nixosSystemFor "x86_64-linux" ./vm.nix;
-    vm-rootless = nixosSystemFor "x86_64-linux" ./vm-rootless.nix;
+    vm-x86_64-linux = nixosSystemFor "x86_64-linux" ./vm.nix;

I think we should do something like x86_64-linux.vm. Would prefer if .#vm just worked out of the box, so perhaps a shortcut like vm = nixosSystemFor system if there's a flake-equivalent of builtins.system that is pure.

— Reply to this email directly, view it on GitHub[https://github.com/pdtpartners/nix-snapshotter/pull/140#pullrequestreview-2117233502], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AURNSZOD7DF53IZPXZWPKUTZHI5CZAVCNFSM6AAAAABJA7ZHHGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXGIZTGNJQGI]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/AURNSZMTLJ2DKRMJ5DEV7IDZHI5CZA5CNFSM6AAAAABJA7ZHHGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT6GJVV4.gif]