search

pducharme / UniFi-Video-Controller

Docker for Unifi-Video Controller (Ubiquiti Networks)
199 stars 105 forks source link

Pull from Github broken again.... #119

Closed kevsterd closed 5 years ago

kevsterd commented 5 years ago

The Docker Hub image is stuck on 3.9.11 when 3.9.12 is latest on GitHub

evanrich commented 5 years ago

3.10 versions are missing from here as well.

kevsterd commented 5 years ago

Yeh. Its what happened last time. The automated push from Git appears to be broken for some reason. Even though there is not much added in .10/.11/.12 I like to keep it up to date when testing.

Perhaps more have migrated over to Protect (I doubt it) and so no one has noticed it stuck...

ruimarinho commented 5 years ago

I am following this as well and I tend to update often to avoid major upgrades.

evanrich commented 5 years ago

~_~ One thing about open source/community produced...is you're not guaranteed updates. @kevsterd @ruimarinho if you are interested in 3.10.0 beta3, I just built it myself:

evanrich/unifi-video-controller:3.10.0-beta3

https://cloud.docker.com/repository/docker/evanrich/unifi-video-controller/general

YMMV, I had to take out the unifi-video.patch because I couldn't get it to successfully patch, hunks failed, so I changed the docker build to use "sed" to replace the contents instead. Just deployed over 3.10.0 beta2 and so far everything seems to be working.

kevsterd commented 5 years ago

One thing about open source/community produced...is you're not guaranteed updates. @kevsterd @ruimarinho if you are interested in 3.10.0 beta3, I just built it myself:

Yep understood. Just a shame when a great effort dosen't get maintained. Yep, I know everyone is busy and its a low priority. This project was seen as a successor to the last one that suffered the same issues. Sad to see.

geekofweek commented 5 years ago

I think it might be an issue with the release branch not getting updated, I think that might be what the docker auto-build is looking at.

domodial commented 5 years ago

hello,

I still can not download version 3.9.12 by this way pducharme / unifi-video-controller: 3.9.12 why ?

fryfrog commented 5 years ago

Sorry for the delay, I don't get notifications for issues and just totally forgot about getting 3.9.12 to release after I tested it on my system. :(

stefancrain commented 5 years ago

I understand this is an annoying attempt at clarifying the causes of this issue. I'm writing it because I hope it helps this group become more involved with this project.

The pull process is not broken, the release process is not broken either. These images were not available on docker hub as they haven't been reported as working with 3.9.12 by anyone that has built the container from master. If you want this in updated in docker hub, pull down the project, build master and test.

Last time this issue came up I did a little research and worked out the release flow here https://github.com/pducharme/UniFi-Video-Controller/issues/116#issuecomment-440017028 and @fryfrog was able to commit https://github.com/pducharme/UniFi-Video-Controller/pull/117 to master. We didn't merge the master branch into the release branch as it wasn't tested by either of us.

IMO the real question here is how do we get the community to test and confirm releases are ready for the general population or automate the testing aspect.

fryfrog commented 5 years ago

I generally run it for a few days and then promote it. The tags let people roll back if it doesn't work and the Unifi people clearly think it is ready. I don't think it needs a lot of testing. I just totally dropped the promotion ball for a variety of reasons. :)

fryfrog commented 5 years ago

Humm, but Docker Hub isn't updating :/

stefancrain commented 5 years ago

@fryfrog I saw that as well, the tag should kick it off!

stefancrain commented 5 years ago

@fryfrog https://status.docker.com/

kevsterd commented 5 years ago

Think that part of the issue is the previous project we all used to use (https://github.com/ctindel/ubiquiti-docker/tree/master/unifi-video) used to auto build/test using Travis

Thanks for explaining the process.... be glad to assist if you come up with a way of us contributing.

chelming commented 5 years ago

it's been two days and docker hub hasn't updated. were builds down at the time that @fryfrog tagged 3.9.12? is there a way to kick it off manually?

fryfrog commented 5 years ago

I pushed another commit to release, deleted the tag and re-created it pointed at the dummy commit instead. I still don't see any activity on Docker Hub.

@pducharme: I don't have admin access to your hub, you're going to have to poke this w/ a stick.

pducharme commented 5 years ago

I triggered the docker build.

fryfrog commented 5 years ago

Can you trigger it for the 3.9.12 tag too?

pducharme commented 5 years ago

There is no tag 3.9.12 on docker hub, donis create one?

fryfrog commented 5 years ago

The linking should be fixed now and I've asked @pducharme to see if the 3.9.12 tag can be triggered. The 3.10.1 build is coming soon too, it is in :beta and :testing right now.