search

pducharme / UniFi-Video-Controller

Docker for Unifi-Video Controller (Ubiquiti Networks)
199 stars 105 forks source link

Create the logs directory, make permissions fixing better w/ 664 for … #62

Closed fryfrog closed 6 years ago

fryfrog commented 6 years ago

Now that logs isn't its own volume, the directory needs to exist at startup or there are errors.

Also, the permissions fixer was just making everything +x. Using find on dirs and files is cleaner, allowing 664 for files and 775 for folders.

I'm building this now and will test shortly.

Still needs to wait until 3.9.2 actually works though. :/

fryfrog commented 6 years ago

Thanks, good catch. Though since the data/videos is a sub folder of /var/lib/unifi-video/, it wouldn't have mattered. In fact, doing it on both might be silly. :/

fryfrog commented 6 years ago

So outside the container, there is a very good reason to separate the "data" (config?) and the videos. You might want to put the videos on a different drive, pool, array or whatever and leave the config in one place.

Inside the container, you're right. I should probably just nuke that second entry because it is literally the same path once it all gets mounted up inside.

I really don't <3 their package. :/

fryfrog commented 6 years ago

Oh, shit now I see what you mean. :/

fryfrog commented 6 years ago

Because of the weird symlinks, inside my container, my video mount is mounted in the right place. But outside the container, it looks like it is going to /usr/lib/unifi-video.

Blech, another thing to untangle.

fryfrog commented 6 years ago

There, removed it entirely since it just isn't needed.

We'll still need to fix up the Dockerfile and README, but that can be post 3.9.2 working.

i8beef commented 6 years ago

@fryfrog yeah, they are replacing the symlink with a mount basically. I'm not sure how docker handles symlinks vs mounts, but it appears like the volume replaces the symlink here... It also appears you could OPTIONALLY mount /var/lib/unifi-video/videos to another volume and its essentially the same thing without messing with /usr stuff... but it's not necessary. Sounds like I'd leave it off, and I'd update the README to reflect that one can optionally mount this /var/lib/unifi-video/videos location to another location to split the storage.