search

pdupavillon / express-recaptcha

Implementation of google recaptcha v2 & V3 solutions for express.js
MIT License
128 stars 21 forks source link

Adapt to Node conventions #1

Closed dogancelik closed 9 years ago

dogancelik commented 9 years ago

All core Node functions and many other popular community modules (mongoose) use function (error) for callback.

If error is null, it is assumed that function worked correctly without any problems. This PR will adapt to this Node convention.

Since we don't have any real data for the verify function, there is no need for success as a second parameter.

Users can check if Recaptcha worked by doing if (!err)

pdupavillon commented 9 years ago

Thanks for the PR :+1:

wozz commented 9 years ago

This is a breaking change... version number should have been bumped to 1.1.0 instead of 1.0.3

pdupavillon commented 9 years ago

My bad, i fixed it