search

pdx-cs-rust-web / knock-knock

class webserver demo spring 2024
Other
2 stars 3 forks source link

created delete method #5

Closed NoodleSamaChan closed 6 months ago

NoodleSamaChan commented 6 months ago

hello!

fixes #4

please don't hesitate to let me know if there are any issues. Cheers!

BartMassey commented 6 months ago

Don't have the earlier PR: guessing you deleted it?

So force-push your whole branch, so that I can get all the commits there.

NoodleSamaChan commented 6 months ago

hello both!

Thanks very much for your feedback, I'm working on including everything!

@BartMassey terribly sorry I'm still quite new to this, this is actually my first PR, I didn't do any other prior to this one : )

@irevoire I've included the HTTP route following the example of utoipa with Axum: https://github.com/juhaku/utoipa/blob/master/examples/todo-axum/src/main.rs I'm not getting any error messages so hopefully I did it properly.

Cheers!

BartMassey commented 6 months ago

@NoodleSamaChan @irevoire I've pushed more changes to the API source, sadly. If you can rebase onto these I'll go ahead and merge this.

NoodleSamaChan commented 6 months ago

@BartMassey okay it should be all good now! Thanks for your patience, don't hesitate to let me know if there are any questions : )

BartMassey commented 6 months ago

Still needed some work, but I went ahead and merged anyhow. I'll rebase my fixes onto the result.

Thanks much for the contribution!