file prefix (-fp) wont work with "-f original"

pe-st / garmin-connect-export

Download a copy of your Garmin Connect data, including stats and GPX tracks.

MIT License

376 stars 77 forks source link

file prefix (-fp) wont work with "-f original" #29

Closed telemaxx closed 4 years ago

telemaxx commented 4 years ago

fit_filename is not really used. fit_filename = directory + '/' + prefix + 'activity_' + activity_id + append_desc + '.fit' with -f gpx it is ok. i will fix that with the next PR for workflow mode

pe-st commented 4 years ago

Thanks for spotting that one.

fit_filename is only used to check if the file was already download. But this check only works for .fit files (original files can also be the very old Garmin .tcx format or manually uploaded .gpx files)

Only when downloading the zip and unzipping it you can know the real extension of the original file.

This was an easy enough error to fix, so I corrected it on my p3 branch...

telemaxx commented 4 years ago

fixed in latest p3 branch