search

pe-st / garmin-connect-export

Download a copy of your Garmin Connect data, including stats and GPX tracks.
MIT License
374 stars 77 forks source link

Add activity typeId filtering #72

Closed joetimmerman closed 8 months ago

joetimmerman commented 2 years ago

Adds the ability to filter based on typeIds as requested in #71. The new --type_filter argument allows you to pass a list of typeIds and only pull activities matching those Ids.

For example: $ python gcexport.py -tf 3 Results in: Filtering out due to typeID, 1 not in [3] : Garmin Connect activity (1/1) [8791243351

joetimmerman commented 2 years ago

@bxsx Appreciate the feedback, will look into adding a test when I have some time.

joetimmerman commented 2 years ago

@pe-st I think this should be good to go now that I've added in @bxsx 's suggestion to use f-strings matching #78

pe-st commented 8 months ago

@joetimmerman I had to slightly adapt your code while rebasing, it's now part of the next version, see https://github.com/pe-st/garmin-connect-export/pull/104

joetimmerman commented 8 months ago

Cheers, thanks for keeping this repo going.

pe-st commented 8 months ago

The code is integrated into Release 4.3.0 (commits 89dd36d1 / b6938d81 / df58afe1)