search

pe-st / garmin-connect-export

Download a copy of your Garmin Connect data, including stats and GPX tracks.
MIT License
364 stars 75 forks source link

Add argument to load/store Garmin SSO data #99

Closed embear closed 6 months ago

embear commented 10 months ago

Garth is able to load and save the SSO data to/from a directory. This speeds up access to Garmin Connect data. Additionally, it is particularly useful when 2FA is enabled in Garmin Connect. Otherwise one has to enter a security code every time you log in, which is very cumbersome when using gcexport in scripts. Because the data is sensitive and not every user may want to store this data by default, this feature is only enabled if the user specifies the -ss/--session argument along with a directory where the SSO data is stored

embear commented 6 months ago

@pe-st Did you have time to look at this PR? Are there any comments or requests for changes?

pe-st commented 6 months ago

Sorry @embear, I initially had no time and then forgot about your PR.

Thanks for proposing this, it will make life (or at least the use of the script) easier for many users, including me.

I have reordered the prompting for username/password, see my branch feature/pr99 (commit b994968), what do you think?

embear commented 6 months ago

@pe-st the your branch works fine for me. Thanks for merging the functionality. I'll close this PR.

pe-st commented 6 months ago

Heree's the PR for 4.3 that includes your code: https://github.com/pe-st/garmin-connect-export/pull/104