Android crash importantForAccessibility

[artfauq]

Hi, The component is working great except on Android device where my app crashes when the picker opens with the error:

It seems to come from this line in the renderOption method:

importantForAccessibility={isFirstItem}

which receives a boolean instead of one of the accepted values.

Versions:

"react-native": "0.62.0",
"react-native-modal-selector": "^2.0.0"

Thanks in advance !

[vicdup]

See https://github.com/peacechen/react-native-modal-selector/pull/142

[peacechen]

@vicdup 's PR has been merged. Before I publish a new version, please validate it on older versions of RN to ensure that it doesn't break them.

Use this in your package.json to pull directly from the repo:

dependencies: {
  "react-native-modal-selector": "https://github.com/peacechen/react-native-modal-selector.git",
}

[nibcortes04]

@vicdup 's PR has been merged. Before I publish a new version, please validate it on older versions of RN to ensure that it doesn't break them.

Use this in your package.json to pull directly from the repo:

dependencies: {
  "react-native-modal-selector": "https://github.com/peacechen/react-native-modal-selector.git",
}

Hola, tengo este mismo error en este momento, agregue en las dependencias lo que dices pero sigue fallando.

[peacechen]

@vicdup @arthurfauq Have you had a chance to test this on current and older versions of RN?

[nibcortes04]

@vicdup @arthurfauq ¿Has tenido la oportunidad de probar esto en versiones actuales y anteriores de RN?

Si, anteriormente lo tenia, lo monte de nuevo en una nueva y no funciona.

[peacechen]

Mi Espanol es no beuno. English please.

Have you tried to pull directly from this repo as noted above https://github.com/peacechen/react-native-modal-selector/issues/141#issuecomment-608023186

Double check that the code in node_modules/react-native-modal-selector/index.js is the most recent. This line should match: https://github.com/peacechen/react-native-modal-selector/blob/master/index.js#L236

Clear the metro and watchman caches to make sure the bundler fetches the updated code. Linux/OSX: https://medium.com/@abhisheknalwaya/how-to-clear-react-native-cache-c435c258834e

Windows: https://mikebridge.github.io/post/clear-react-native-caches/

[nibcortes04]

Mi Espanol es no beuno. English please.

Have you tried to pull directly from this repo as noted above #141 (comment)

Double check that the code in node_modules/react-native-modal-selector/index.js is the most recent. This line should match: https://github.com/peacechen/react-native-modal-selector/blob/master/index.js#L236

Clear the metro and watchman caches to make sure the bundler fetches the updated code. Linux/OSX: https://medium.com/@abhisheknalwaya/how-to-clear-react-native-cache-c435c258834e

Windows: https://mikebridge.github.io/post/clear-react-native-caches/

Perfecto, muchas gracias.

[nochkin]

Double check that the code in node_modules/react-native-modal-selector/index.js is the most recent. This line should match: https://github.com/peacechen/react-native-modal-selector/blob/master/index.js#L236

Tested fine for me. Thank you.

[peacechen]

Published in 2.0.1