search

peacechen / react-native-modal-selector

A cross-platform (iOS / Android), selector/picker component for React Native that is highly customizable and supports sections.
MIT License
369 stars 129 forks source link

Current release breaks web view in react native #158

Closed SebCodesStuff closed 3 years ago

SebCodesStuff commented 3 years ago

React native no longer supports RNViewPropTypes, View.PropTypes, or Text.PropTypes.

This is a breaking change for your index.js file.

I've still been working with your package and when needed I have been changing any mention of these types to an any in order to get the project running. I'd recommend implementing this or creating an interface to mirror the now missing PropTypes.

Ex of my local fix

- style:                          ViewPropTypes.style,
+ style:                          PropTypes.any,
peacechen commented 3 years ago

Thanks for noting this issue. Would you mind submitting a PR?

SebCodesStuff commented 3 years ago

Can do I'll have something up shortly

SebCodesStuff commented 3 years ago

@peacechen I've created the pr but when pushing my branch I got a 403. Do I need to be added to the contributor list in order to push my branch? If so please add me

mikaello commented 3 years ago

@SebCodesStuff you should create a fork of this repository and push your branch to that fork, and then create a pull request across forks (you will get this screen if you click "New pull request" under tab "Pull requests"):

across forks
peacechen commented 3 years ago

@SebCodesStuff Any progress on creating the PR?

I'm curious how FB expects people to validate prop types after remove View.PropTypes. PropTypes.any seems like a blunt instrument as a replacement.

peacechen commented 3 years ago

Fix published in 2.0.4