Open vincerubinetti opened 4 years ago
Thank you for the suggestion. Good idea.
I'm assuming usage like the following.
- name: Deploy
uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./public
dry_run: ${{ github.event_name == 'pull_request' }}
Could you test #513 as follows?
- name: Deploy
uses: peaceiris/actions-gh-pages@41f7401 #513
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
dry_run: ${{ github.event_name == 'pull_request' }}
Sorry for the delay. It seems like it worked:
https://github.com/vincerubinetti/word4word/runs/1295010202?check_suite_focus=true
Hi @peaceiris,
what is the status of this Issue? I can see a PR already. Is it working? Why is it not yet merged? If there are still some TODO's for the PR I might be able to support (if OK of course).
This feature would be very nice to have.
BR
npm-publish has a nice feature called
--dry-run
that lets you test what the command is going to do without actually doing it. It might be nice to have something like that inactions-gh-pages
.It could look like this:
That way, on each pull request, I can see if this
actions-gh-pages
step in the CI workflow throws any errors, and I can get a list of what would've been published to thegh-pages
branch (and any other helpful info). This would give me confidence that it will work fine when pushing/merging into master.