search

peachpiecompiler / peachpie

PeachPie - the PHP compiler and runtime for .NET and .NET Core
https://www.peachpie.io
Apache License 2.0
2.33k stars 202 forks source link

Feature/local debugging #1031

Closed kendallb closed 2 years ago

kendallb commented 2 years ago

Add support for local builds of .net 4.61. I need to use this to be able to build correctly and debug .net 4.61 versions of the library. I cannot seem to debug .net standard. Can we somehow get this into the master tree as well?

jakubmisek commented 2 years ago

Isn't it sufficient to add 

<TargetFrameworks>netcoreapp3.1;net461</TargetFrameworks>

to the dummy.msbuildproj ?

although wouldn't it start failing on Linux/Mac?

kendallb commented 2 years ago

its been a while since I wrote that so I could debug it. When you build it in master as local debugging, it works for you? I wonder if I am missing some dependencies or something as it won't link for me in our solution.

jakubmisek commented 2 years ago

I'm using the dummy project with netcoreapp3.1 and it works for me for .NET Framework as well; (it causes the NuGet cache update with all its targets)

kendallb commented 2 years ago

Ok, deleting this. It all works now. I have no idea why I needed that ages ago when I first was debugging it, but it works fine now.