search

peachpiecompiler / peachpie

PeachPie - the PHP compiler and runtime for .NET and .NET Core
https://www.peachpie.io
Apache License 2.0
2.33k stars 202 forks source link

Fixes C14N, PDO.PgSQL, chr() #1066

Open kripper opened 2 years ago

kripper commented 2 years ago

@jakubmisek here is a patch for the C14N bug. Can you also please merge my helper function "peachpie_set_string_encoding()" which is required to change encoding and be able to work with ISO-8859-1 sources. It won't harm the project, but will be usefull/required to work with ISO-8859-1 sources.

jakubmisek commented 2 years ago

thanks @kripper

jakubmisek commented 2 years ago

Can we have the PR without the change to Strings.cs, it's totally unrelated to the issue.

thank you

kripper commented 1 year ago

Please note that the helper method needed for working with iso-8859-1 and utf-8 at the same time, was reverted here: https://github.com/peachpiecompiler/peachpie/commit/280800183060e500a1c0ae0020663ec1b7536970

We have been using this method in production for years and we really need it, since there is no other option.

Having this method in our code, is also an obstacle for us to release pull requests of all other fixes that are required upstream.

We don't know how to deal with this method.