Fix php value conversion for sbyte and short

peachpiecompiler / peachpie

PeachPie - the PHP compiler and runtime for .NET and .NET Core

https://www.peachpie.io

Apache License 2.0

2.31k stars 201 forks source link

Fix php value conversion for sbyte and short #1104

Closed jameschung2000 closed 1 year ago

jameschung2000 commented 1 year ago

@jakubmisek , here is a patch for issue 1103, it upscales the sbyte and short to integer in PhpValue FromClr function, which can fix the problem that PDO not able to handle TinyInt and SmallInt fields. Could you please take a look and merge it?

dnfadmin commented 1 year ago

All CLA requirements met.

jakubmisek commented 1 year ago

thank you! I'll just change the unnecessary use System.Convert.ToInt32 and merge it