search

peak-ai / jedlik

DynamoDB ODM for Node
MIT License
106 stars 4 forks source link

aws-sdk should only be a peerDependency #24

Closed rickihastings closed 3 years ago

rickihastings commented 3 years ago

Is your feature request related to a problem? Please describe. It looks like this library is providing it's own aws-sdk dependency, this means if it's being used in conjunction with other AWS services (which it is in our micro services), because of this we are bundling multiple versions of the aws-sdk into the Lambda, this is going to have an adverse affect on cold starts, deployment times and memory usage.

Describe the solution you'd like aws-sdk should be in peerDependencies (and devDependencies) and not dependencies.

Describe alternatives you've considered n/a

Additional context n/a

rickihastings commented 3 years ago

I'll pick this up at some point, just putting this issue here as a reminder

rickihastings commented 3 years ago

I think this is fine actually, it's using a caret, done some digging into yarn.lock files and it seems it's pinning multiple versions to one version of aws-sdk. Going to close.