peak / s5cmd

Parallel S3 and local filesystem execution tool.
MIT License
2.67k stars 237 forks source link

Please create a new release with updated `github.com/lanrat/extsort` version #717

Open gkowarzyk opened 6 months ago

gkowarzyk commented 6 months ago

Hello,

The github.com/lanrat/extsort library has created a new release tag (v1.0.1), which includes the latest fixes, and changes the license from GPL to an Apache v2 license.

Please create a new release with the updated github.com/lanrat/extsort version, as it would allow s5cmd to include the new license in its dependencies instead.

Thanks in advance!

Redeys commented 6 months ago

takemetakemeit of noting ### toadsi`version: 2 updates:

Dependencies listed in go.mod

Redeys commented 6 months ago

[account](tu

bitfis h it's not about then [**)**](bit of the game ### code)

kucukaslan commented 2 weeks ago

Hi team,

What do you think about upgrading extsort's version?

I suppose updating go.mod and vendor/ would be enough. If needed I can open a PR.

Ideally a github action, using https://github.com/google/go-licenses, to check license compatibility can be added to ensure such a mistake won't happen again but I cannot promise doing it.

I also want to make a kind of reflection (retro?) since I was the one added this dependency 😅 . I vaguely remember that I checked the license because I was interested in FOSS and inter-compability of GNU-GPL license variants with ours. at https://github.com/lanrat/extsort/issues/3 we see that project license was changed to Apache in 2021 (a year before we started using it) at GitHub repo. Probably, I merely checked the GitHub repo and thought it is fine, and did not investigate further.

Bests

jrnos commented 2 weeks ago

I think it would be good to update the version in order to get Apache v2 license into effect.